Track My Order
Frequently Asked Questions
International Shipping Info
Mon-Fri, 9am to 12pm and
1pm to 5pm U.S. Mountain Time:
Chat With Us
there seems to be an error in the code snippet for the buffering example: Setting a pointer (probably in the window struct) to the allocated memory (the buffer) is missing
( setWindowMemory(..) ???)
Thanks spotting that! I couldn't find anything in the Buffering Example on GitHub. Is this the right file? Could you suggest a line # or something so I can find it more easily?
it should be line 79,80 in the example source you linked.
And in the original library source, the signature for the fn appears here: https://github.com/sparkfun/SparkFun_HyperDisplay/blob/00116e434827b70a261ad61d895cd0583bbb611b/src/hyperdisplay.h#L174
Okay so I gave it a look-over and still couldn't see the missing pointer setting. In lines 79-80 there are two different functions being called - one sets the memory for the current window and the other requires that you specify which window to set the memory for. That might be able to account for the confusion. If it doesn't and there's still trouble will you consider posting a pull request with your desired changes on GitHub? Or if not that then just an issue with a screenshot of what you're seeing would be good.
ohhh, I see where we've mis-communicated. I meant that in the actual tutorial write-up, there is a code snippet called out; In the page here: https://learn.sparkfun.com/tutorials/everything-you-should-know-about-hyperdisplay/buffering
...there is a code-snippet, right below the words "Here's how that process might look in code:"
My point was simply that in that excerpt, the actual code for setting the buffer memory is missing. This might be misleading/confusing because the paragraph right above it makes an explicit point about the need to set the buffer memory
.The example code itself that you linked is correct (i.e. it uses the right function call)
My apologies for not being more clear as to what I perceived the "mistake" to be
Aha! Thanks for explaining, I see now. I'll go over and fix that snippet :)
I love the idea of the "Beerware" license. Also, HyperDisplay looks awesome! Well done!
If you've found a bug or have other constructive feedback for our tutorial authors, please send us your feedback!
Forgot your password?
No account? Register one!